Implement PreviousViews stack #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted a comment from
codecov-io
Aug 31, 2019
Repository owner
deleted a comment from
codecov-io
Aug 31, 2019
Repository owner
deleted a comment from
codecov-io
Sep 1, 2019
Repository owner
deleted a comment from
codecov-io
Sep 2, 2019
Repository owner
deleted a comment from
codecov-io
Sep 2, 2019
|
Nice! Code looks good, and I gave it a functional test |
jesseduffield
approved these changes
Sep 7, 2019
Codecov Report
@@ Coverage Diff @@
## master #159 +/- ##
=======================================
Coverage 26.44% 26.44%
=======================================
Files 13 13
Lines 1138 1138
=======================================
Hits 301 301
Misses 821 821
Partials 16 16Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #158
Needs more investigation, cause PreviousViews stack keeps growing with time.should be ok now